Field extensions: spec edits #1196
Draft
+44
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
martinbonnin
reviewed
Oct 8, 2025
Contributor
martinbonnin
left a comment
martinbonnin
left a comment
There was a problem hiding this comment.
Thanks for looking into this! Few comments below
BoD
reviewed
Oct 9, 2025
martinbonnin
changed the title
martinbonnin
changed the title
spec/Section 3 -- Type System.md
Outdated
Comment on lines
1137
to
1140
| 4. The deprecation reason may be added if none exists, or must match the | ||
| existing reason exactly | ||
| 5. Directives may be added but cannot conflict with existing non-repeatable | ||
| directives |
Contributor
There was a problem hiding this comment.
I think we should remove 4. as a sub-case of 5. @deprecated is not repeatable so it's not valid to add @deprecated from a type extension, even if it's the exact same deprecation reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.